On Wed, Jul 15, 2015 at 10:18:26PM -0700, Joe Stringer wrote: > This check in parse_ofp_str__() attempted to detect inconsistencies > between matches and actions, or inconsistencies within the actions. In > this case, ofpacts_check() would effectively zero the "usable_protocols" > and return 0 (ie, OK). However, when checking the return parameter, it > checks the pointer rather than the value. > > In practice, this seems to only come up for fields which are used > internally in OVS and not exposed for matching from the controller, like > tunnel flags or skb_priority. > > Found by MIT STACK analyzer. > > Signed-off-by: Joe Stringer <joestrin...@nicira.com>
This has patch rejects but the ofp-parse change is obviously correct, thanks! Acked-by: Ben Pfaff <b...@nicira.com> _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
