On Sat, Jul 04, 2015 at 10:38:34PM -0700, Alex Wang wrote:
> As we have more daemons with OVN that can be tested using ovs autotest
> framework, it is convenient to extend check_logs() to check the log files
> of all daemons.
> 
> Signed-off-by: Alex Wang <al...@nicira.com>
> 
> ---
> PATCH->V2:
> - make check_logs() check all daemons' log files.

I was a little confused at first about why we weren't just using *.log,
but you set me straight in IM about this identifying testsuite.log
incorrectly.  I think that the following form (which I haven't tested)
would make that more obvious.  Also, this will find logfiles even if
their pidfiles get deleted.

check_logs () {
    local logs
    for log in *.log; do
        case $log in # (
            '*.log'|testsuite.log) ;; # (
            *) logs="$logs $log" ;;
        esac
    done
    sed -n "$1
/timeval.*Unreasonably long [[0-9]]*ms poll interval/d
/timeval.*faults: [[0-9]]* minor, [[0-9]]* major/d
/timeval.*disk: [[0-9]]* reads, [[0-9]]* writes/d
/timeval.*context switches: [[0-9]]* voluntary, [[0-9]]* involuntary/d
/ovs_rcu.*blocked [[0-9]]* ms waiting for .* to quiesce/d
/|WARN|/p
/|ERR|/p
/|EMER|/p" $logs
}

Thanks,

Ben.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to