On Wed, Jul 01, 2015 at 06:57:50PM +0000, Alin Serdean wrote: > Since commit: > https://github.com/openvswitch/ovs/commit/2e460098bff351b9fddcb917447caa3b97a35d86 > a new packet attribute was introduced. > > This patch adds OVS_PACKET_ATTR_PROBE to nlPktExecPolicy in datapath-windows > and ignores it for the moment to maintain binary compatibility. > > Signed-off-by: Alin Gabriel Serdean <[email protected]> > Acked-by: Eitan Eliahu <[email protected]> > --- > This patch should be applied on master and branch-2.4 > v2: add acked-by
This patch makes me worry a bit. The Linux kernel and OVS userspace implementations of Netlink ignore attributes that they do not recognize, which allows for some kinds of compatibility. To me, this patch implies that the Windows datapath reports an error when it sees an unrecognized attribute. Is that correct? If so, then that should be changed, because otherwise it will cause compatibility problems in the future. _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
