On Tue, Jun 30, 2015 at 4:43 PM, Sabyasachi Sengupta
<sabyasachi.sengu...@alcatel-lucent.com> wrote:
>
>> Is actually adding a new feature rather than fix a bug?
>
>
> Actually v2 fixes a bug that was in the original patch (v1) that was sent
> out.
>
Ah, We usually write version delta comments in a separate section,
with a heading of "v1->v2: "
The general comment is only about the patch itself.
>> If so, you may also want to update the man pages with the new usage
>> and add unit tests for it.
>
>
> I'll add the manpage extension and resend v3, but I'm not sure about the
> unit tests that needs to be added. Can you point me to what needs to be done
> to the framework?
OVS uses autotest framework, The tests are in the "tests" directory. Look into
ovsdb-tool.at for examples.
>
>> If this patch also fixes bugs, then the bug fix should be in a separate
>> patch.
>
>
> No, it does not fix any bug. It just fixes a defect in my original
> implementation.
>
>> What would be default argument for the new 'table' argument if it is
>> not specified?
>
>
> It dumps the whole db as indicated in the usage:
>
> dump [SERVER] [DATABASE] [TABLE]
> dump contents of table(s) in DATABASE on SERVER to stdout
>
> "TABLE" is optional.
>
That's fine. The default is all tables. It should be documented.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
