I actually meant to ask about the validation for this patch. Was any simulation/synthetic test done to validate the new code being introduced in the patch?
thanks, -- Nithin > On Jun 18, 2015, at 5:19 PM, Alin Serdean <aserd...@cloudbasesolutions.com> > wrote: > > Acked-by: Alin Gabriel Serdean <aserd...@cloudbasesolutions.com> > > > -----Mesaj original----- > De la: dev [mailto:dev-boun...@openvswitch.org] În numele Sorin Vinturis > Trimis: Thursday, June 18, 2015 9:37 PM > Către: dev@openvswitch.org > Subiect: [ovs-dev] [PATCH v2] datapath-windows: Return success for already > existing WFP objects > > There are cases when the WFP callout or sublayer, being persistent objects, > already exists when we try to register the OVS callout. In this cases, when > trying to add again these WFP objects the return code is > STATUS_FWP_ALREADY_EXISTS, which we are interpreting as an error. > This is incorrect and this patch changes that. > > Signed-off-by: Sorin Vinturis <svintu...@cloudbasesolutions.com> > Reported-by: Sorin Vinturis <svintu...@cloudbasesolutions.com> > Reported-at: > https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_openvswitch_ovs-2Dissues_issues_84&d=BQIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=pNHQcdr7B40b4h6Yb7FIedI1dnBsxdDuTLBYD3JqV80&m=umMY3HnXv8fdLTcQtxoqybZLeN7nSGmABAJG-MYc5Ac&s=8mABzUpAzOmx_dhTzCwXCbB7ew0SwOYf-nV8r4xopcA&e= > > --- > datapath-windows/ovsext/TunnelFilter.c | 13 +++++++++++-- > 1 file changed, 11 insertions(+), 2 deletions(-) > > diff --git a/datapath-windows/ovsext/TunnelFilter.c > b/datapath-windows/ovsext/TunnelFilter.c > index 08cc13f..231750e 100644 > --- a/datapath-windows/ovsext/TunnelFilter.c > +++ b/datapath-windows/ovsext/TunnelFilter.c > @@ -414,7 +414,12 @@ OvsTunnelRegisterDatagramDataCallouts(const GUID > *layerKey, > > status = FwpmCalloutAdd(gEngineHandle, &mCallout, NULL, NULL); > if (!NT_SUCCESS(status)) { > - goto Exit; > + if (STATUS_FWP_ALREADY_EXISTS != status) { > + OVS_LOG_ERROR("Failed to add WFP callout, status: %x.", > + status); > + goto Exit; > + } > + status = STATUS_SUCCESS; > } > > Exit: > @@ -459,7 +464,11 @@ OvsTunnelRegisterCallouts(VOID *deviceObject) > > status = FwpmSubLayerAdd(gEngineHandle, &OvsTunnelSubLayer, NULL); > if (!NT_SUCCESS(status)) { > - goto Exit; > + if (STATUS_FWP_ALREADY_EXISTS != status) { > + OVS_LOG_ERROR("Failed to add WFP sublayer, status: %x.", > + status); > + goto Exit; > + } > } > > /* In order to use this callout a socket must be opened. */ _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
