> On Jun 12, 2015, at 3:41 PM, Ben Pfaff <b...@nicira.com> wrote: > > On Fri, Jun 12, 2015 at 02:36:24PM -0700, Jarno Rajahalme wrote: >> Add support for port mods in an OpenFlow 1.4 bundle, as required for >> the minimum support level by the OpenFlow 1.4 specification. If the >> bundle includes port mods, it may not specify the OFPBF_ATOMIC flag. >> Port mods and flow mods in a bundle are always applied in order and >> the consecutive flow mods between port mods are made available to >> lookups atomically. >> >> Note that ovs-ofctl does not support creating bundles with port mods. >> >> Signed-off-by: Jarno Rajahalme <jrajaha...@nicira.com> > > I only looked at the new changes to DESIGN.md since I acked the rest > before. > > s/accoross/across/ here: > +modification. This design amortizes the cost of datapath cache > +flushing accoross multiple flow table changes, and has a significant > > s/accross/across/ and s/arbitraty/arbitrary/ here: > +With OpenFlow 1.4 bundles this atomicity can be extended accross an > +arbitraty set of flow_mods. Bundles are supported for flow_mod and > > Acked-by: Ben Pfaff <b...@nicira.com>
Thanks for the fixes! On the other files, I noticed that ofproto->visible_version may only differ from ofproto->tables_version within do_bundle_commit(), so I changed that to a local variable instead. Applied to master, Jarno _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
