On Thu, Jun 11, 2015 at 01:20:27PM -0700, Andy Zhou wrote: > On Sat, Jun 6, 2015 at 2:23 PM, Ben Pfaff <b...@nicira.com> wrote: > > On Mon, Jun 01, 2015 at 12:29:28AM -0700, Andy Zhou wrote: > >> On Fri, May 29, 2015 at 1:05 PM, Ben Pfaff <b...@nicira.com> wrote: > >> > On Thu, Apr 09, 2015 at 06:40:28PM -0700, Andy Zhou wrote: > >> > The current implementation of ovsdb_monitor_commit() throws away the > >> > cache whenever there is any commit to the database. However, most > >> > monitors do not every table and every column. Do you think it would be > >> > worthwhile flushing the cache only when a column that is included in the > >> > monitor changes? > >> > > >> This is a good idea. However, I don't see a way to easily extend current > >> patch > >> to add this patch. So I sent out v4 without this enhancement. > > > > I am OK with this patch set without the enhancement; it could be added > > later. But I don't see why it requires much more work. It seems to me > > like the code already looks at each of the changes; why not just flush > > only if one of the changes affects a column that the monitor looks at? > > Thanks for the suggestion. I took a closer look and implemented a > three patch series that try to minimize the monitor changes by > ignoring changes that does not apply. Then extending this logic to > optimize Json cache flush. Please let me know if this approach is too > complicated. > > The first of the three patch series is: > http://openvswitch.org/pipermail/dev/2015-June/056233.html
Thanks, I will review it. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
