On Thu, Jun 11, 2015 at 01:45:44PM -0400, Russell Bryant wrote:
> On 06/10/2015 11:15 AM, Ben Pfaff wrote:
> > We've had this question a couple of times so we might as well document it.
> > 
> > Requested-by: Saurabh Shrivastava (सौरभ श्रीवास्तव) <saur...@gmail.com>
> > Signed-off-by: Ben Pfaff <b...@nicira.com>
> > ---
> >  AUTHORS         | 1 +
> >  lib/ovsdb-idl.h | 6 +++++-
> >  2 files changed, 6 insertions(+), 1 deletion(-)
> > 
> > diff --git a/AUTHORS b/AUTHORS
> > index 5ad3c1a..fb4ebb6 100644
> > --- a/AUTHORS
> > +++ b/AUTHORS
> > @@ -328,6 +328,7 @@ Ronaldo A. Ferreira     ronal...@cs.princeton.edu
> >  Ronny L. Bull           bul...@clarkson.edu
> >  Sander Eikelenboom      li...@eikelenboom.it
> >  Saul St. John           sstj...@cs.wisc.edu
> > +Saurabh Shrivastava (सौरभ श्रीवास्तव)    saur...@gmail.com
> >  Scott Hendricks         shendri...@nicira.com
> >  Sean Brady              sbr...@gtfservices.com
> >  Sebastian Andrzej Siewior  sebast...@breakpoint.cc
> > diff --git a/lib/ovsdb-idl.h b/lib/ovsdb-idl.h
> > index 54df90d..d0c025a 100644
> > --- a/lib/ovsdb-idl.h
> > +++ b/lib/ovsdb-idl.h
> > @@ -1,4 +1,4 @@
> > -/* Copyright (c) 2009, 2010, 2011, 2012, 2013, 2014 Nicira, Inc.
> > +/* Copyright (c) 2009, 2010, 2011, 2012, 2013, 2014, 2015 Nicira, Inc.
> >   *
> >   * Licensed under the Apache License, Version 2.0 (the "License");
> >   * you may not use this file except in compliance with the License.
> > @@ -23,6 +23,10 @@
> >   * raw JSON into data structures that are easier for clients to digest.  
> > Most
> >   * notably, references to rows via UUID become C pointers.
> >   *
> > + * The IDL always presents a consistent snapshot of the database to its 
> > client,
> > + * that is, it won't present the effects of some part of a transaction 
> > applied
> > + * at the database server without presenting all of its.
> > + *
> 
> The addition seems like a good one, but the last sentence ends weird,
> like a word was left off.  Maybe "its changes." ?

Thanks, for consistency with the rest of the sentence I used "its
effects."

That's a good enough review for me, for a comment change, so I applied
this to master.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to