> > > > On 10/06/2015 12:48, "Gray, Mark D" <mark.d.g...@intel.com> wrote: > > > >The vhost port won't generate an RSS hash because it is a virtual NIC. > > > >> > > > >> It doesn't cause a problem, just make the pkt fall into a slow path, > >>should we > > > >> fix it? > > Thanks for investigating this. We should definitely fix it. > > > > >> The flag ol_flags may be useful for OVS or let DPDK fix this in vhost > >>rcv. > > > > > > > >How do you propose that this would work? The RSS would still have to be > > > >generated in software. > > > >> > > A simple solution would be to reset the RSS hash inside > netdev_dpdk_vhost_rxq_recv(). Other netdev providers that do not > support reading the RSS hash (netdev-linux, netdev-bsd) call > dp_packet_set_rss_hash(pkt, 0) on every received packet.
I thought Dongjun was suggesting that we should generate a hash? I agree that it should be reset on every received packet. I upstreamed something similar for dpdkr ports. The proposal above seems good to me. > > This would probably have a small impact on performance, but it's better than > trashing the exact match cache. > > I don't believe there's anything that DPDK can do here (like resetting the > hash when the packet is freed), but please correct me if I'm wrong. > > Thoughts? > > > > >> _______________________________________________ > > > >> dev mailing list > > > >> dev@openvswitch.org > > > >> > >>https://urldefense.proofpoint.com/v2/url?u=http- > 3A__openvswitch.org_ma > >>ilm > >>an_listinfo_dev&d=BQIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw- > YihVMNtXt-uEs > >>&r= > >>SmB5nZacmXNq0gKCC1s_Cw5yUNjxgD4v5kJqZ2uWLlE&m=3J9Uq22LocYzd > Ok0zaAg-I-B > >>XRc Q0C4xUYMUbB04iLg&s=vWwQ3E9pNyybTCXbUTmvxkrUiP- > Y30yTAB6RBxe2DOI&e= > > > >_______________________________________________ > >dev mailing list > >dev@openvswitch.org > >https://urldefense.proofpoint.com/v2/url?u=http- > 3A__openvswitch.org_mai > >lma > >n_listinfo_dev&d=BQIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw- > YihVMNtXt-uEs&r > >=Sm > >B5nZacmXNq0gKCC1s_Cw5yUNjxgD4v5kJqZ2uWLlE&m=3J9Uq22LocYzdOk0 > zaAg-I-BXRc > >Q0C 4xUYMUbB04iLg&s=vWwQ3E9pNyybTCXbUTmvxkrUiP- > Y30yTAB6RBxe2DOI&e= _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
