Hi Ben, Thanks for your inputs. We will share the updated patch. Kindly suggest for the below point..
>This adds abstracted OFPUTIL_TABLE_CONFIG_* but it doesn't do any >translation between them and OFPTC14_*. As per the openflow specs. 1.4, OFPTC14_* values are defined only for eviction and vacancy events (as OFPTC14_EVICTION and OFPTC14_VACANCY_EVENTS), but there is no OFPTC14_* value defined for "no-evict" feature. Please suggest can we use OFPTC11_TABLE_MISS_* values for the same, as the comment in the definition of ofp_table_config for OFPTC11_TABLE_MISS_* values, in openflow-common.h suggest that " /* OpenFlow 1.1 and 1.2 defined this field as shown. * OpenFlow 1.3 and later mark this field as deprecated, but have not * reused it for any new purpose. */" So when "no-evict" is set through mod-table command (for OF1.4 or greater) to disable eviction , can any one of OFPTC11_TABLE_MISS_* values be used? Thanks and Regards, Saloni Jain Tata Consultancy Services Mailto: saloni.j...@tcs.com Website: http://www.tcs.com ____________________________________________ Experience certainty. IT Services Business Solutions Consulting ____________________________________________ -----Ben Pfaff <b...@nicira.com> wrote: ----- To: saloni.jai...@gmail.com From: Ben Pfaff <b...@nicira.com> Date: 06/05/2015 10:32PM Cc: dev@openvswitch.org, Saloni Jain <saloni.j...@tcs.com>, deepankar.gu...@tcs.com, partha.da...@tcs.com Subject: Re: [ovs-dev] [PATCH v9] ovs-ofctl:Implementation of eviction on the basis of Importance On Fri, May 29, 2015 at 04:00:27PM +0530, saloni.jai...@gmail.com wrote: > From: Saloni Jain <saloni.j...@tcs.com> > > This commit enables the eviction mechanism on the basis of importance as > per the openflow specification 1.4. > > "ovs-ofctl -O OpenFlow14 mod-table <switch> <table> evict" > Enable eviction on <table> of <switch>. Eviction adds a mechanism > enabling the switch to automatically eliminate entries of lower > importance to make space for newer entries.If want to enable eviction > on all tables, user can set the <table> as 'ALL'. > > "ovs-ofctl -O OpenFlow14 mod-table <switch> <table> noevict" > Disable eviction on <table> of <switch>. > > "ovs-ofctl -O OpenFlow14 dump-tables-desc <switch>" > This command provides a way to list the current configuration > (eviction for importance) of the tables on a <switch>, which is set > using the mod-table command. > > Signed-off-by: Saloni Jain <saloni.j...@tcs.com> This adds abstracted OFPUTIL_TABLE_CONFIG_* but it doesn't do any translation between them and OFPTC14_*. This adds a weird CLEAR_EVICTION_BIT definition. Use an OFPUTIL_TABLE_CONFIG_* constant. This leaves in the following comment that is now obsolete: /* We do not understand any properties yet, so we do not bother * parsing them. */ It appears to me that all of the OFPUTIL_TABLE_CONFIG modes are mutually exclusive. Why are they individual bits? Alternatively, there is a bit for "NO_EVICTION" and one for "EVICTION"; why both? Why does this expression contain parentheses? return UINT32_MAX - (rule->importance); =====-----=====-----===== Notice: The information contained in this e-mail message and/or attachments to it may contain confidential or privileged information. If you are not the intended recipient, any dissemination, use, review, distribution, printing or copying of the information contained in this e-mail message and/or attachments to it are strictly prohibited. If you have received this communication in error, please notify us by reply e-mail or telephone and immediately and permanently delete the message and any attachments. Thank you _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
