On 8 May 2015 at 09:15, Ben Pfaff <b...@nicira.com> wrote: >> On 8 May 2015, at 09:28, Kavanagh, Mark B <mark.b.kavan...@intel.com> wrote: >> >>> -Wno-cast-align is a CFLAG, not a configure option. >>> >>> Signed-off-by: Joe Stringer <joestrin...@nicira.com> >>> --- >>> .travis/build.sh | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/.travis/build.sh b/.travis/build.sh >>> index c7796e1..6dfc9fe 100755 >>> --- a/.travis/build.sh >>> +++ b/.travis/build.sh >>> @@ -74,7 +74,7 @@ if [ "$DPDK" ]; then >>> install_dpdk $DPDK_VER >>> if [ "$CC" = "clang" ]; then >>> # Disregard cast alignment errors until DPDK is fixed >>> - EXTRA_OPTS="$EXTRA_OPTS -Wno-cast-align" >>> + CFLAGS="$CFLAGS -Wno-cast-align" >> >> Hi Joe, >> >> I was on the fence about where to put this flag - ultimately, I decided that >> if it were passed at the configure stage, then any subsequent 'make's >> wouldn't need the additional flag. >> However, I fully agree with this change. > > I think that the issue was that "configure -Wno-cast-align" doesn't make > sense. If you wanted to usefully pass this at configure time, it would > have to be "configure CFLAGS=-Wno-cast-align".
Right, the travis error was: configure: error: unrecognized option: `-Wno-cast-align' Try `./configure --help' for more information This looks like a reasonable place to have this check, with the rest of the DPDK logic. I'll push this to master soon, thanks for looking over it. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
