> On Apr 29, 2015, at 11:48 PM, Ben Pfaff <[email protected]> wrote:
>
> + enum lex_type lookahead = lexer_lookahead(ctx->lexer);
> + if (lookahead == LEX_T_EQUALS || lookahead == LEX_T_LSQUARE) {
I don't think it's clear that bit-level assignment is supported in the ovn-sb
man page. It might be nice to add.
> + parse_set_action(ctx);
> + } else if (lexer_match_id(ctx->lexer, "next")) {
> + emit_resubmit(ctx, ctx->table_id + 1);
Do you want to enforce that table_id is not equal to the max table_id? Maybe
it's okay, because the next table won't have any flows so it will get dropped?
It still seems surprising, and an error message might be nice.
> + } else if (lexer_match_id(ctx->lexer, "output")) {
> + emit_resubmit(ctx, 64);
The next patch is the one that limits the available table ids to 32, so this
value of 64 looks a little odd. Also, I think it's worth documenting somewhere
what the different tables mean.
Acked-by: Justin Pettit <[email protected]>
--Justin
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
