On Fri, 24 Apr 2015 13:06:04 -0400 Russell Bryant <rbry...@redhat.com> wrote:
> [PATCH 1/2] Add ovn-ctl to assist with OVN daemon lifecycle. > [PATCH 2/2] fedora.spec: Create openvswitch-ovn package. > > ovn/automake.mk > | 1 > ovn/utilities/.gitignore > | 1 > ovn/utilities/automake.mk > | 9 > ovn/utilities/ovn-ctl > | 277 ++++++++++ > ovn/utilities/ovn-ctl.8.xml > | 54 + > rhel/automake.mk > | 8 > rhel/openvswitch-fedora.spec.in > | 51 + > rhel/usr_lib_systemd_system_ovncontroller-nonetwork.service > | 14 > rhel/usr_lib_systemd_system_ovncontroller.service > | 13 > rhel/usr_lib_systemd_system_ovnnorthd-nonetwork.service > | 14 > rhel/usr_lib_systemd_system_ovnnorthd.service > | 13 > rhel/usr_share_openvswitch_scripts_systemd_ovncontroller_sysconfig.template > | 14 > rhel/usr_share_openvswitch_scripts_systemd_ovnnorthd_sysconfig.template > | 32 + 13 files changed, 495 insertions(+), 6 deletions(-) > As we discussed this on IRC, I think copying the ovs systemd units isn't a good idea because OVS can be used to build the host network and so it needs to run before network or it can depend on the host network (have access to controllers). Therefore there is a special care to bring up the services with the right dependencies which at least to me doesn't make sense to OVN. Since OVN will build a virtual network on top of the host network, I think the systemd unit could be a standard single one. Regarding to sysconfig file, we have that for OVS because it was being used with old SysV service file, so we kept it around. However, since OVN doesn't have that please try to avoid that specially with standard fixed parameters. It also makes harder for others to run where the /etc/sysconfig is not the standard location. Just create the service and pass the full command line. Last thing, systemd is designed to manage the daemon directly, so a wrapper script makes things more difficult. If you can take that out (not sure if it's possible), it would be better from systemd perspective IMO. fbl _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
