Thanks, applied.
On Tue, Apr 21, 2015 at 03:53:39PM -0700, Justin Pettit wrote:
> Acked-by: Justin Pettit <jpet...@nicira.com>
>
>
> > On Apr 21, 2015, at 2:22 PM, Ben Pfaff <b...@nicira.com> wrote:
> >
> > Elsewhere, I think we just write ... to indicate that there can be more
> > than one, and let it be understood otherwise.
> >
> > I want to add a "lport-set-port-security" command that has a similar format
> > and don't want to use up extra vertical space to mention that you can have
> > more than one argument.
> >
> > Signed-off-by: Ben Pfaff <b...@nicira.com>
> > ---
> > ovn/ovn-nbctl.8.xml | 2 +-
> > ovn/ovn-nbctl.c | 7 +++----
> > 2 files changed, 4 insertions(+), 5 deletions(-)
> >
> > diff --git a/ovn/ovn-nbctl.8.xml b/ovn/ovn-nbctl.8.xml
> > index 477db7a..32fd165 100644
> > --- a/ovn/ovn-nbctl.8.xml
> > +++ b/ovn/ovn-nbctl.8.xml
> > @@ -124,7 +124,7 @@
> > each key-value pair.
> > </dd>
> >
> > - <dt><code>lport-set-macs</code> <var>lport</var> [<var>mac</var>]
> > [<var>mac</var>] [...]</dt>
> > + <dt><code>lport-set-macs</code> <var>lport</var>
> > [<var>mac</var>]...</dt>
> > <dd>
> > Sets the MACs associated with <var>lport</var> to
> > <var>mac</var>. Multiple MACs may be sets by using multiple
> > diff --git a/ovn/ovn-nbctl.c b/ovn/ovn-nbctl.c
> > index 02dc0ad..61ec1e9 100644
> > --- a/ovn/ovn-nbctl.c
> > +++ b/ovn/ovn-nbctl.c
> > @@ -70,9 +70,8 @@ Logical port commands:\n\
> > set or delete an external-id on LPORT\n\
> > lport-get-external-id LPORT [KEY]\n\
> > list one or all external-ids on LPORT\n\
> > - lport-set-macs LPORT [MAC] [MAC] [...]\n\
> > - set MAC addresses for LPORT. Specify more\n\
> > - than one using additional arguments.\n\
> > + lport-set-macs LPORT [MAC]...\n\
> > + set MAC addresses for LPORT.\n\
> > lport-get-macs LPORT get a list of MAC addresses on LPORT\n\
> > lport-get-up LPORT get state of LPORT ('up' or 'down')\n\
> > \n\
> > @@ -624,7 +623,7 @@ static const struct ovs_cmdl_command all_commands[] = {
> > },
> > {
> > .name = "lport-set-macs",
> > - .usage = "LPORT [MAC] [MAC] [...]",
> > + .usage = "LPORT [MAC]...",
> > .min_args = 1,
> > /* Accept however many arguments the system will allow. */
> > .max_args = INT_MAX,
> > --
> > 2.1.3
> >
> > _______________________________________________
> > dev mailing list
> > dev@openvswitch.org
> > http://openvswitch.org/mailman/listinfo/dev
>
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
