>
> I know some of you are concerned about it will break build on Windows.
> The diff below fixes pthread linking on FreeBSD.
> Tested on Linux, NetBSD, and FreeBSD.
You can also check whether it builds successfully on Windows by adding
your proposed commit to your fork of OVS in Github and then logging
into appveyor.com via your github account. You can then start a new
build there

If you prefer that I take care of Windows, let me know.


>
> If it looks good, I'll update the commit message, thanks.
>
> diff --git a/acinclude.m4 b/acinclude.m4
> index b09f2f2..c5214dc 100644
> --- a/acinclude.m4
> +++ b/acinclude.m4
> @@ -710,6 +710,7 @@ dnl    glibc: HAVE_GLIBC_PTHREAD_SETNAME_NP
>  dnl    NetBSD: HAVE_NETBSD_PTHREAD_SETNAME_NP
>  dnl    FreeBSD: HAVE_PTHREAD_SET_NAME_NP
>  AC_DEFUN([OVS_CHECK_PTHREAD_SET_NAME],
> +  [AC_CHECK_LIB(pthread, pthread_create)]
>    [AC_CHECK_FUNCS([pthread_set_name_np])
>     if test $ac_cv_func_pthread_set_name_np != yes; then
>       AC_CACHE_CHECK(
> diff --git a/configure.ac b/configure.ac
> index d1b48ca..9d1dbf3 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -81,7 +81,6 @@ AC_SUBST([LT_AGE])
>  AC_SEARCH_LIBS([pow], [m])
>  AC_SEARCH_LIBS([clock_gettime], [rt])
>  AC_SEARCH_LIBS([timer_create], [rt])
> -AC_SEARCH_LIBS([pthread_sigmask], [pthread])
>  AC_FUNC_STRERROR_R
>
>  OVS_CHECK_ESX
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to