On Thu, Apr 16, 2015 at 3:35 PM, Pravin Shelar <pshe...@nicira.com> wrote:
> On Thu, Apr 16, 2015 at 3:15 PM, Jesse Gross <je...@nicira.com> wrote:
>> On Tue, Apr 14, 2015 at 8:46 PM, Pravin B Shelar <pshe...@nicira.com> wrote:
>>> diff --git a/datapath/linux/compat/stt.c b/datapath/linux/compat/stt.c
>>> new file mode 100644
>>> index 0000000..f294ecd
>>> --- /dev/null
>>> +++ b/datapath/linux/compat/stt.c
>>> +static u8 skb_get_l4_proto(struct sk_buff *skb, __be16 l3_proto)
>>> +{
>>> + if (l3_proto == htons(ETH_P_IP)) {
>>> + unsigned int nh_ofs = skb_network_offset(skb);
>>> +
>>> + if (unlikely(!pskb_may_pull(skb, nh_ofs + sizeof(struct
>>> iphdr))))
>>> + return 0;
>>
>> Is this sufficient to cover the checks in stt_can_offload() as well?
>>
> ok, I will add tcp-header len to the pull request.
We could potentially have UDP here too so we should be careful to not
throw out good packets in that case.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
