Dear Ben
Thanks for comments. Team is working on comments and will revert back once
they have been resolved.
Thanks & Regards
Deepankar Gupta
______________
Experience certainty. IT Services
Business Solutions
Consulting
____________________________________________
From: Ben Pfaff <b...@nicira.com>
To: Rishi Bamba <rishi.ba...@tcs.com>
Cc: dev@openvswitch.org, deepankar gupta <deepankar.gu...@tcs.com>,
partha datta <partha.da...@tcs.com>, saloni jain <saloni.j...@tcs.com>,
hiteshi kalra <hiteshi.ka...@tcs.com>
Date: 04/01/2015 05:24 AM
Subject: Re: REMINDER: [PATCH] ovs-ofctl: Implementation of
eviction on the basis of Importance
On Sat, Mar 21, 2015 at 03:18:39PM +0530, Rishi Bamba wrote:
> Hope you are doing fine.
> We are awaiting response from you & the OVS Team regarding the patch
"ovs-ofctl: Implementation of eviction on the basis of Importance" which
is already under review.
> The last revised patch was sent on 11.02.2015 as per the comments
received from you.
The code still has problems even after multiple rounds of review.
Even after I asked specifically about it, you still have not fixed
issues with indentation.
You don't version your patches and describe what has changed from one
version to another, like everyone else.
You don't bother to read and follow CodingStyle.md.
You write code that contains cut-and-paste duplication.
Fix all of that and I'll take another look.
=====-----=====-----=====
Notice: The information contained in this e-mail
message and/or attachments to it may contain
confidential or privileged information. If you are
not the intended recipient, any dissemination, use,
review, distribution, printing or copying of the
information contained in this e-mail message
and/or attachments to it are strictly prohibited. If
you have received this communication in error,
please notify us by reply e-mail or telephone and
immediately and permanently delete the message
and any attachments. Thank you
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
