On Fri, Apr 10, 2015 at 07:30:13AM -0700, Gurucharan Shetty wrote: > On Thu, Apr 9, 2015 at 8:42 PM, Michael Hu <humich...@nicira.com> wrote: > > Currently if --syslog-target=127.0.0.1:514 is enabled, syslog would have > > duplicated log messages. The fix will not call syslog() if already having > > syslog_fd indicating message is sent through udp. > > You forgot to add a Signed-off-by. > When I 'git am' this patch, I get: > Applying: vlog.c: Avoid duplicating log message in rsyslog if enabling > syslog-target > fatal: corrupt patch at line 15 > > I personally think that your patch makes sense. But the documentation > (e.g. 'man ovs-vswitchd') says: > > --syslog-target=host:port > Send syslog messages to UDP port on host, in addition to the > system syslog. The host must be a numerical IP address, not a > hostname. > > So when this feature was added, I think it was mostly meant for a > remote IP address and not local. So your patch breaks the "in > addition" part of the current expectation.
I'd like to hear why one would pass --syslog-target=127.0.0:514 at all. Why is this useful, if the system already has a working syslog() facility? Thanks, Ben. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
