They are left out because those functions are used only by the MACROs
PERF_FUNCTON_COUNT_BEGIN
PERF_FUNCTON_COUNT_END
Both macros have been defined to empty for a non-linux platform.
On Tue, Apr 14, 2015 at 12:41 PM, Russell Bryant <rbry...@redhat.com> wrote:
> On 04/14/2015 03:37 PM, Andy Zhou wrote:
>> Commit '97a3c43515e' misses definitions for non-Linux platforms thus
>> broke builds for any non-Linux platform.
>>
>> Signed-off-by: Andy Zhou <az...@nicira.com>
>> ---
>> lib/perf-counter.h | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
>>
>> diff --git a/lib/perf-counter.h b/lib/perf-counter.h
>> index b5b72e5..c9abf72 100644
>> --- a/lib/perf-counter.h
>> +++ b/lib/perf-counter.h
>> @@ -131,6 +131,16 @@ char *perf_counters_to_string(void);
>>
>> #define PERF_FUNCTON_COUNT_BEGIN
>> #define PERF_FUNCTON_COUNT_END
>> +
>> +static inline void perf_counters_init(void) {}
>> +static inline void perf_counters_destroy(void) {}
>> +static inline void perf_counters_clear(void) {}
>> +static inline char *
>> +perf_counters_to_string(void)
>> +{
>> + return xstrdup("Not Supported on this platform. Only available on
>> Linux.");
>> +}
>> +
>> #endif
>>
>> #endif
>>
>
> There were a couple other functions:
>
> uint64_t perf_counter_read(uint64_t *counter);
> void perf_counter_accumulate(struct perf_counter *counter,
> uint64_t start_count);
>
> Is there a reason those are left out, or should they be added too?
>
> --
> Russell Bryant
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
