On Mon, Apr 13, 2015 at 11:15 AM, Pravin Shelar <pshe...@nicira.com> wrote: > On Thu, Apr 9, 2015 at 11:15 AM, Jesse Gross <je...@nicira.com> wrote: >> diff --git a/datapath/linux/compat/gso.h b/datapath/linux/compat/gso.h >> index 337d13a..dce4c67 100644 >> --- a/datapath/linux/compat/gso.h >> +++ b/datapath/linux/compat/gso.h >> @@ -52,6 +52,15 @@ static inline int skb_inner_network_offset(const struct >> sk_buff *skb) >> return skb_inner_network_header(skb) - skb->data; >> } >> >> +/* We don't actually store the transport offset on backports because >> + * we don't use it anywhere. Slightly rename this version to avoid >> + * future users from picking it up accidentially. >> + */ > Can we add WARN_ON() to catch this case?
I'm not sure what condition we would warn on this case. This function actually does get called today, the issue is if there is a newer caller expects that this returns a value other than 0. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
