On 04/10/2015 03:57 PM, Terry Wilson wrote:
> This adds very basic support for setuptools so that the OVS Python
> lib can be added to PyPI.

Most Python libraries are on PyPI, so it makes sense to put this one
there, too.  Another specific reason this would be helpful is that in
OpenStack, certain test enviornments are built as Python virtual
environments, and the contents of those virtualenvs is Python packages
installed from PyPI.  Not having this one there means we can't use this
library in a set of the test jobs.

Ideally uploading to PyPI would become part of the ovs release process
whenever a tarball is published.

If you don't want to do that but are willing to delegate it, someone
else (like Terry) could take on the responsibility to do it after an ovs
release is made.  It's not so different than a distro package maintainer
updating their distro package of this lib.  In the case of PyPI, there's
not really a distro, so it kind of makes sense to me for the upstream to
"own" keeping it updated.

> This currently uses the Open vSwitch version number and the
> generated dirs.py, though there is no real reason to tie the
> Python libraries releases or version numbers to the main project's.

Changing it could cause unnecessary pain since the library is already
packaged and installed via distro packages using the ovs version number,
so I think it makes sense to do it the way you have it.

I see you added your Signed-off-by in a reply.  The patch looks good to me.

Acked-by: Russell Bryant <rbry...@redhat.com>

-- 
Russell Bryant
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to