On Wed, Apr 01, 2015 at 04:33:15PM +0100, [email protected] wrote:
> From: Billy O'Mahony <[email protected]>
> 
> Unlike system interfaces, DPDK enabled interfaces must have their interface
> type explicitly set when used to create bonded ports.  Mention this at the
> relevant points in the documentation.
> 
> Signed-off-by: Billy O'Mahony <[email protected]>

Thanks for working on the documentation!

I'm not sure why this is worth mentioning only at one particular point
in the FAQ.  Every single add-bond or add-port in the FAQ potentially
needs to be followed up by setting the correct interface type, right?
It's not even complicated.

It might be worth adding a new FAQ (or FAQ section for DPDK) that says
to set the Interface types when adding ports or bonds.

>           ovs-vsctl add-br br0
>           ovs-vsctl add-bond br0 bond0 eth0 eth1
>  
> -     Bonds have tons of configuration options.  Please read the
> -     documentation on the Port table in ovs-vswitchd.conf.db(5)
> +     Bonds have tons of configuration options and the configuration
> +     for DPDK enabled interfaces is less straightforward.  Please read
> +     the documentation on the Port table in ovs-vswitchd.conf.db(5)
>       for all the details.
>  
>     - Perhaps you don't actually need eth0 and eth1 to be on the

Here, again I'm not sure why this is just for bonds.  Non-bonded ports
need the same treatment, right?

> @@ -282,7 +282,9 @@ is an error.  With \fB\-\-may\-exist\fR, this command 
> does nothing if
>  .IP "[\fB\-\-fake\-iface\fR] \fBadd\-bond \fIbridge port iface\fR\&... 
> [\fIcolumn\fR[\fB:\fIkey\fR]\fR=\fIvalue\fR]\&...\fR"
>  Creates on \fIbridge\fR a new port named \fIport\fR that bonds
>  together the network devices given as each \fIiface\fR.  At least two
> -interfaces must be named.
> +interfaces must be named.  If the interfaces are DPDK enabled then
> +the transaction will need to include operations to explicitly set the
> +interface type to 'dpdk'.
>  .IP
>  Optional arguments set values of column in the Port record created by
>  the command.  The syntax is the same as that for the \fBset\fR command

Thanks,

Ben.
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev

Reply via email to