On Thu, Mar 19, 2015 at 12:08:42AM -0700, Andy Zhou wrote: > Although multiple jsonrpc monitor can share the same ovsdb monitor, each > change still needs to transalted into json object from scratch. This > can be wastful is mutiple jsonrpc monitors are interested in the > same changes. > > Json chche impoves this by keeping an copy of json object generated > for transaction X to current transaction. When jsonrpc is interested > in a change, the cache is lookup first, if an json object is found, > a copy of it is handed back, skipping the regeneration process. > > Any commit to the monitor will empty the cache. since none of them > will be useful anymore. > > Signed-off-by: Andy Zhou <az...@nicira.com>
I'm surprised to see this as a global hmap instead of a per-ovsdb_monitor hmap. It seems like the latter would be more straightforward given that a flush operation destroys all of the cache nodes related to an ovsdb_monitor. I have some overall comments on the series, I'll add them to patch 0. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
