On Fri, Mar 27, 2015 at 11:44:07PM -0700, Alex Wang wrote: > When cfm is deleted from a port, all modules should release their > reference so that the cfm struct can be removed from the global hmap > and freed. Therein, the reference held by xlate module can only be > released when the need_revalidate flag is set (e.g set to > REV_RECONFIGURE). And this flag should be set while removing cfm > from ofport. Unfortunately, this has never been done before and the > bug was hidden by another bug fixed in recent commit a190839 > (netdev-vport: Do not update netdev when there is no config change.) > > To fix this issue, this commit makes the code set need_revalidate > when removing cfm from ofport. > > Signed-off-by: Alex Wang <[email protected]>
Thanks for figuring this out. I think that the new version will force a reconfiguration for set_cfm(ofport, NULL) even if 'ofport' didn't have any CFM configured. That seems wrong to me. _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
