On Thu, Mar 26, 2015 at 4:11 AM, Traynor, Kevin <kevin.tray...@intel.com> wrote: > >> -----Original Message----- >> From: Ben Pfaff [mailto:b...@nicira.com] >> Sent: Thursday, March 26, 2015 4:28 AM >> To: Traynor, Kevin >> Cc: dev@openvswitch.org >> Subject: Re: [ovs-dev] [PATCH] netdev-dpdk: Put cuse thread into quiescent >> state. >> >> On Wed, Mar 25, 2015 at 05:43:06PM +0000, Kevin Traynor wrote: >> > As ovsrcu_synchronize() is used when setting virtio_dev to NULL, >> > ovsrcu_quiesce_start() must be called before destroy_device() returns. >> > Otherwise there will be warnings about the thread not quiescing. >> > Use of ovs_thread_create() instead of pthread_create() is optional but >> > as we are now setting quiescent state, it is added. >> > >> > Signed-off-by: Kevin Traynor <kevin.tray...@intel.com> >> >> Is the quiescent state permanent? Normally ovsrcu_quiesce_start() and >> ovsrcu_quiesce_end() should be paired, but this patch only seems to add >> the former. > > ovsrcs_quiesce_end() is called as part of the ovsrcu_syncronize() call when > destroy_device() is called. I could put an explicit ovsrcu_quiesce_end() call > for readability if that's preferred? It would be redundant in terms of > functionality but would show the start/end pair. Otherwise I could add a > comment to explain.
I changed this part of original patch so that there is no need for the fuse thread enter into quiescent state. But I think it is unavoidable without changing RCU implementation. So we need this patch. If you add comments and resend I will apply it. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
