On Thu, Mar 19, 2015 at 06:03:27PM -0700, Jarno Rajahalme wrote: > The flow key should be the same regardless of whether a live bucket is > found or not, as it would be confusing that the flow key would be > different (different mask bits) after the last group bucket goes dead. > > In general, the megaflow algorithm expects the mask bits be set as > soon as we read the header bits, regardless of what happens > afterwards. > > Also, use flow_mask_hash_fields() instead of individually setting mask > fields. This immediately brings in IPv6 support, and helps keeping > masks in sync with potential algorithm changes to flow hashing > functions. > > Found by inspection. > > Signed-off-by: Jarno Rajahalme <jrajaha...@nicira.com>
Beautiful. A bug fix that removes code. Thank you! Acked-by: Ben Pfaff <b...@nicira.com> _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
