Sure Ben. Will do that. -----Original Message----- From: Ben Pfaff [mailto:b...@nicira.com] Sent: Monday, 16 March, 2015 18:06 To: Sorin Vinturis Cc: Nithin Raju; dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH 3/3] netlink: support for asynchronous NL transactions
Hi Sorin. Thanks for the patches. When you think that discussion has settled down, would you mind posting a v2 of this series that includes the Acked-by:s that you have received? Thanks. On Mon, Mar 16, 2015 at 09:49:14AM +0000, Sorin Vinturis wrote: > Hi Nithin, > > If there are pending IRPs to process and a stop is received, then all > remaining IRPs are completed with STATUS_CANCELLED. No BSOD occurs. > > I was not aware that there is another thread waiting for async calls in the > userspace. I have tested the driver without this patch and, indeed, the async > calls are correctly handled. In this case I will drop this patch. > > Thanks, > Sorin > > -----Original Message----- > From: Nithin Raju [mailto:nit...@vmware.com] > Sent: Sunday, 15 March, 2015 18:27 > To: Sorin Vinturis > Cc: dev@openvswitch.org > Subject: Re: [ovs-dev] [PATCH 3/3] netlink: support for asynchronous > NL transactions > > > On Mar 12, 2015, at 5:42 PM, Sorin Vinturis > > <svintu...@cloudbasesolutions.com> wrote: > > > > Modified 'nl_sock_transact_multiple__' function to send asynchronous > > I/O requests to the kernel driver. > > > > Signed-off-by: Sorin Vinturis <svintu...@cloudbasesolutions.com> > > Reported-by: Alin Gabriel Serdean <aserd...@cloudbasesolutions.com> > > Reported-at: > > https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_open > > vs > > witch_ovs-2Dissues_issues_64&d=AwIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeA > > w- > > YihVMNtXt-uEs&r=pNHQcdr7B40b4h6Yb7FIedI1dnBsxdDuTLBYD3JqV80&m=ptyT-4 > > _K > > X9K220F3nw2WYFTDxbFegQddmHarVmB6PKc&s=__1QDaT8DB13yENZfteePG67ZSDCfl > > B3 > > F6hDW29RCjY&e= > > --- > > lib/netlink-socket.c | 26 ++++++++++++++++++++++---- > > 1 file changed, 22 insertions(+), 4 deletions(-) > > Hypothetically, if the kernel does not complete the IRP, then one or more of > the userspace threads is stuck on GetOverlappedResult(). If you Ctrl-C the > ovs-vswitchd process at that point, what happens to the pending IRP? Does it > get cleaned up as part of process exit, or will we get a PSOD? > > thanks, > -- Nithin > _______________________________________________ > dev mailing list > dev@openvswitch.org > http://openvswitch.org/mailman/listinfo/dev _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
