> -----Original Message----- > From: Ben Pfaff [mailto:b...@nicira.com] > On Fri, Mar 06, 2015 at 03:37:37PM +0000, Mark D. Gray wrote: > > From: "Mark D. Gray" <mark.d.g...@intel.com> > > > > datapath_types and port_types columns will allow an ovsdb client to > > determine the available datapath and port types on this instance of > > ovs-vswitchd > > > > Signed-off-by: Mark D. Gray <mark.d.g...@intel.com> > > Signed-off-by: Billy O'Mahony <billy.o.mah...@intel.com> > > ... > > > + <group title="Capabilities"> > > + <p> > > + These columns report capabilities of the Open vSwitch instance. Any > > + value reported in these columns should be detected from probing > Open > > + vSwitch. > > What does the second sentence mean? Checking published lists of > capabilities is essentially the opposite of probing for them.
We will update this > > > + </p> > > + <column name="datapath_types"> > > + <p> > > + This column reports the different dpifs registered with the > > system. > > + </p> > > + </column> > > + <column name="port_types"> > > + <p> > > + This column reports the different netdevs registered with the > system. > > The available port types can vary based on the datapath, so I'm not sure that > it makes sense to publish them without that context. I think ideally we would like to get to that stage (i.e. be able to tell that a datapath supports a particular port type). I can't think of a way off-hand to do that by probing. I think it would have to be done by a list that could be modified by updating the code and recompiling. > > > + </p> > > + </column> > > + </group> > > + > > <group title="Database Configuration"> > > <p> > > These columns primarily configure the Open vSwitch database > > diff --git a/vtep/automake.mk b/vtep/automake.mk index > > 7892685..d19e4cf 100644 > > --- a/vtep/automake.mk > > +++ b/vtep/automake.mk > > @@ -87,7 +87,7 @@ vtep/vtep.ovsschema.stamp: vtep/vtep.ovsschema > > touch $@; \ > > else \ > > ln=`sed -n '/"cksum":/=' $?`; \ > > - echo >&2 "$?:$$ln: checksum \"$$sum\" does not match (you > should probably update the version number and fix the checksum)"; \ > > + echo >&2 "$?:$$ln: The checksum \"$$sum\" was calculated from > the > > +schema file and does not match cksum field in the schema file (you > > +should probably update the version number and the checksum in the > > +schema file)"; \ > > exit 1; \ > > These updates to make the error messages more helpful would be suitable > as an independent patch. Ok _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
