On Fri, Mar 06, 2015 at 11:19:16AM +0900, YAMAMOTO Takashi wrote: > > Until now "ovs-ofctl add-flows ..." command sent each OFPC_ADD > > request one by one accompanied with a barrier request. This > > meant that before ovs-ofctl could send next OFPC_ADD request > > it had to wait for a barrier response that was sent together > > with previous OFPC_ADD request. > > > > After this patch ovs-ofctl batches together all OFPC_ADD requests > > and sends only a single barrier request for the last OFPC_ADD > > request. As a result of this patch, ovs-ofctl was able to insert > > 60K flows in 1 second instead of 7 seconds. This is especially > > helpful when restarting ovs-vswitchd. > > > > One possible side effect of this patch is that ovs-ofctl > > might ignore some error messages that resulted in failed > > OFPC_ADD. > > this seems like a semantic change in cases where > the order of requests matter, right? > have you considered to make it optional?
It is a semantic change. Making it optional seems like a good idea to me too. I think an option name like "--fast" would give the right impression. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
