On Thu, Mar 05, 2015 at 09:24:28PM -0500, Russell Bryant wrote:
> The default_gw attribute of a logical router was defined as an IP
> address in ovn-nb.xml, but as a boolean in ovn-nb.ovsschema.  Fix the
> schema to reflect that this is an IP address.
> 
> Signed-off-by: Russell Bryant <rbry...@redhat.com>

I think this patch reflects a misunderstanding of the "min" and "max"
key-values pairs in a schema.  They limit the number of elements.  Thus,
a column of type {"type": {"key": "string", "min": 0, "max": 1}} may
contain one string or none.

>  ovn/ovn-nb.ovsschema | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/ovn/ovn-nb.ovsschema b/ovn/ovn-nb.ovsschema
> index ad675ac..a02ad7e 100644
> --- a/ovn/ovn-nb.ovsschema
> +++ b/ovn/ovn-nb.ovsschema
> @@ -45,7 +45,7 @@
>          "Logical_Router": {
>              "columns": {
>                  "ip": {"type": "string"},
> -                "default_gw": {"type": {"key": "string", "min": 0, "max": 
> 1}},
> +                "default_gw": {"type": "string"},
>                  "external_ids": {
>                      "type": {"key": "string", "value": "string",
>                               "min": 0, "max": "unlimited"}}}},
> -- 
> 2.1.0
> 
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to