On Wed, Mar 4, 2015 at 1:26 PM, Ben Pfaff <b...@nicira.com> wrote: > On Wed, Mar 04, 2015 at 11:25:50AM -0800, Justin Pettit wrote: > > Signed-off-by: Justin Pettit <jpet...@nicira.com> > > I agree that this is more user-friendly but it runs the risk that > someone will name an smap column "row" or "datum" or "auto" or > "switch" or "goto" or "double" or ... > > Maybe that isn't a realistic problem. At least we'd get a good error > message from the compiler. That's good enough for me I guess. >
I agree that could be a problem, but all the other "_set_" functions use the name of the column in the argument. I'll push this change so it's consistent, and then we can decide later whether we want to change all of them. Thanks for the review. --Justin _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
