On Fri, Feb 20, 2015 at 4:41 PM, Jesse Gross <je...@nicira.com> wrote:
> On Fri, Feb 20, 2015 at 4:34 PM, Pravin Shelar <pshe...@nicira.com> wrote:
>> On Fri, Feb 20, 2015 at 3:37 PM, Jesse Gross <je...@nicira.com> wrote:
>>> There are two important GSO tunnel features that were introduced
>>> after the 3.12 cutoff for our current out of tree GSO implementation:
>>>  * 3.16 introduced support for outer UDP checksums.
>>>  * 3.18 introduced support for verifying hardware support for protocols
>>>    other than VXLAN.
>>>
>>> In cases where these features are used, we should use OVS GSO to
>>> ensure correct behavior. However, we also want to continue to use
>>> kernel GSO or hardware TSO in existing situations. Therefore, this
>>> extends the range of kernels where OVS GSO is available to 3.18 and
>>> makes it easier to select which one to use.
>>>
>>> Signed-off-by: Jesse Gross <je...@nicira.com>
>>> Acked-by: Thomas Graf <tg...@noironetworks.com>
>>> Acked-by: Pravin B Shelar <pshe...@nicira.com>
>>> ---
>>> v2: Fix compilation on kernels 3.12 and 3.17.
>>> v3: Dramatically simplify kernel version checks by using backports
>>>     for almost everything on pre-3.18 kernels and just using GSO
>>>     where available.
>>> v4: Use backport iptunnel_xmit() instead of many version checks.
>>> ---
>>
>> This patch looks good to me. But I did not tried all kernel since it
>> forth patch does not apply anymore. So if you have already tested it,
>> I am happy with series pushed to master.
>
> Thanks to both you and Thomas for reviewing. I pushed the series to master.
>
> I did build tests on a hopefully representative set of both upstream
> and RHEL kernels as well as functional tests. I didn't test it
> exhaustively against all possible kernels - do you have a script to do
> this? If you do, you can run it against master now. The changes from
> the previous series should be pretty minimal so hopefully I didn't
> break anything else.

It work fine with kernels that I have. Thanks.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to