Pushed both patches with the change suggested. Thanks for the review Ben.

On Sun, Feb 22, 2015 at 10:59 AM, Ben Pfaff <b...@nicira.com> wrote:
> On Fri, Feb 20, 2015 at 01:22:12PM -0800, Andy Zhou wrote:
>> When debugging multiple programs under GDB, it will be easier to
>> identify xterms with the program name displayed as title. Without
>> this patch, xterms will have the title of "gdb", which is the first
>> program the xterm executes. This change is useful for the next patch.
>>
>> Signed-off-by: Andy Zhou <az...@nicira.com>
>
> ...
>
>>  run_xterm() {
>> -    run xterm -e "$@" &
>> +    title=$1;
>> +    shift
>> +    run xterm -T $title -e "$@"  &
>
> I would put $title in "" here.
>
>>  }
>
> Acked-by: Ben Pfaff <b...@nicira.com>
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to