On Wed, Jan 21, 2015 at 03:38:48PM -0800, Sabyasachi Sengupta wrote: > I saw that bundle_destroy calls mbridge_unregister_bundle with bundle->aux. > However the second parameter of mbridge_unregister_bundle is ofbundle. When > creating the bundle in mbridge_bundle_register, we setup mbundle using > ofbundle. Shouldn't the call to unregister be just ofbundle pointer instead? > I'm wondering how would otherwise mbridge_unregister_bundle find the mirror > bundle and clean it up? Is there a memory leak? > > --- a/ofproto/ofproto-dpif.c > +++ b/ofproto/ofproto-dpif.c > @@ -2343,7 +2343,11 @@ bundle_destroy(struct ofbundle *bundle) > } > > ofproto = bundle->ofproto; > - mbridge_unregister_bundle(ofproto->mbridge, bundle->aux); > + mbridge_unregister_bundle(ofproto->mbridge, bundle);
I agree. I pushed a fix. Thanks a lot! _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
