You are right. I will drop the patch.
On Wed, Jan 7, 2015 at 7:27 PM, Ben Pfaff <b...@nicira.com> wrote: > On Wed, Jan 07, 2015 at 07:55:11PM -0800, Andy Zhou wrote: >> Out of tree builds failed when trying to find the er-diagram *.pic >> files. Fixing by adding proper source path. >> >> Signed-off-by: Andy Zhou <az...@nicira.com> > > I don't understand this patch. vswitch.pic is generated in the build > directory: > >> vswitchd/vswitch.pic: vswitchd/vswitch.gv ovsdb/dot2pic >> $(AM_V_GEN)(dot -T plain < vswitchd/vswitch.gv | $(PERL) >> $(srcdir)/ovsdb/dot2pic -f 3) > $@.tmp && \ >> mv $@.tmp $@ > > so I don't understand why one would look for it in the source directory: > >> -VSWITCH_PIC = vswitchd/vswitch.pic >> +VSWITCH_PIC = $(srcdir)/vswitchd/vswitch.pic > > Thanks, > > Ben. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev