Sorin,

I copied here the link command line for Win8 and Win8.1. Please note that 
Win8.1 uses different libraries:

Win8:
/OUT:"x64\Win8Debug\OVSExt.sys" /MANIFEST:NO /PROFILE /Driver 
/PDB:"x64\Win8Debug\OVSExt.pdb" "C:\Program Files (x86)\Windows 
Kits\8.1\lib\win8\KM\x64\BufferOverflowFastFailK.lib" "C:\Program Files 
(x86)\Windows Kits\8.1\lib\win8\KM\x64\ntoskrnl.lib" "C:\Program Files 
(x86)\Windows Kits\8.1\lib\win8\KM\x64\hal.lib" "C:\Program Files (x86)\Windows 
Kits\8.1\lib\win8\KM\x64\wmilib.lib" "C:\Program Files (x86)\Windows 
Kits\8.1\lib\win8\KM\x64\ndis.lib" "C:\Program Files (x86)\Windows 
Kits\8.1\lib\win8\KM\x64\fwpkclnt.lib" "C:\Program Files (x86)\Windows 
Kits\8.1\lib\winv6.3\UM\x64\uuid.lib" "C:\Program Files (x86)\Windows 
Kits\8.1\lib\win8\KM\x64\netio.lib" /RELEASE /VERSION:"6.3" /DEBUG /MACHINE:X64 
/ENTRY:"GsDriverEntry" /WX /OPT:REF /INCREMENTAL:NO 
/PGD:"x64\Win8Debug\OVSExt.pgd" /SUBSYSTEM:NATIVE",6.02" /OPT:ICF 
/ERRORREPORT:PROMPT /MERGE:"_TEXT=.text;_PAGE=PAGE" /NOLOGO /NO

Win8.1:
/OUT:"x64\Win8.1Debug\OVSExt.sys" /MANIFEST:NO /PROFILE /Driver 
/PDB:"x64\Win8.1Debug\OVSExt.pdb" "C:\Program Files (x86)\Windows 
Kits\8.1\lib\winV6.3\KM\x64\BufferOverflowFastFailK.lib" "C:\Program Files 
(x86)\Windows Kits\8.1\lib\winV6.3\KM\x64\ntoskrnl.lib" "C:\Program Files 
(x86)\Windows Kits\8.1\lib\winV6.3\KM\x64\hal.lib" "C:\Program Files 
(x86)\Windows Kits\8.1\lib\winV6.3\KM\x64\wmilib.lib" "C:\Program Files 
(x86)\Windows Kits\8.1\lib\winV6.3\KM\x64\ndis.lib" "C:\Program Files 
(x86)\Windows Kits\8.1\lib\winV6.3\KM\x64\fwpkclnt.lib" "C:\Program Files 
(x86)\Windows Kits\8.1\lib\winv6.3\UM\x64\uuid.lib" "C:\Program Files 
(x86)\Windows Kits\8.1\lib\winV6.3\KM\x64\netio.lib" /RELEASE /VERSION:"6.3" 
/DEBUG /MACHINE:X64 /ENTRY:"GsDriverEntry" /WX /OPT:REF /INCREMENTAL:NO 
/PGD:"x64\Win8.1Debug\OVSExt.pgd" /SUBSYSTEM:NATIVE",6.03" /OPT:ICF 
/ERRORREPORT:PROMPT /MERGE:"_TEXT=.text;_PAGE=PAGE" /NOLOGO /NODEFAULTLIB 
/SECTION:"INIT,d"


This easiest thing would be replicate the Win8.1 already in the project and add 
the NDIS 6.40 setting to the new replica. Then remove Win8 project.

Please let me know if there is any issue.
Thank you.
Eitan


-----Original Message-----
From: Sorin Vinturis [mailto:svintu...@cloudbasesolutions.com] 
Sent: Monday, November 24, 2014 9:26 AM
To: Eitan Eliahu; dev@openvswitch.org
Subject: RE: [PATCH v2] datapath-windows: Update OVSEXT VS project to support 
6.40

Eitan,

I did not removed anything from the existing VS project. I have only changed 
the compiler settings, visible from project's properties --> Configuration 
properties --> C/C++ --> Preprocessor --> Preprocessor Definitions.

For Win8 Release & Win8 Debug the above value was not changed and it is the 
following: 
"%(PreprocessorDefinitions);NDIS_WDM=1;NDIS630=1".

For Win8.1 Release & Win8.1 Debug the above value was changed into the 
following: 
"%(PreprocessorDefinitions);NDIS_WDM=1;NDIS640=1".

All remaining settings were not changed.

For example, when selecting 'Win8.1 Release' build configuration, because of 
the NDIS640=1 setting, the headers for NDIS 6.40 will be included into the 
OVSEXT project, making the OVS extension an NDIS 6.40 compliant driver.

-Sorin


-----Original Message-----
From: Eitan Eliahu [mailto:elia...@vmware.com] 
Sent: Monday, 24 November, 2014 19:08
To: Sorin Vinturis; dev@openvswitch.org
Subject: RE: [PATCH v2] datapath-windows: Update OVSEXT VS project to support 
6.40

Sorin, did you remove Win8 project? Can we have 8.1 WInDDK libraries for both 
6.30 and 6.40 drivers?
Thanks,
Eitan

-----Original Message-----
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Sorin Vinturis
Sent: Monday, November 24, 2014 9:03 AM
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH v2] datapath-windows: Update OVSEXT VS project to 
support 6.40

Added support for creating OVS extension driver NDIS 6.40 compliant.

Currently the OVSEXT Visual Studio project has four build configurations,
'Win8 Release', 'Win8 Debug', 'Win8.1 Release' and 'Win8.1 Debug'. All of them 
are creating a binary that is NDIS 6.30 compliant. I have changed the
Win8.1 build configurations in order to create a binary that is NDIS 6.40 
compliant.

In this way, the OVSEXT project is able to create a release/debug binary that 
is NDIS 6.30 compliant, using the 'Win8 Release' and 'Win8 Debug'
build configurations, as well as a release/debug binary that is NDIS 6.40 
compliant, using the 'Win8.1 Release' and 'Win8.1 Debug' build configurations.

Signed-off-by: Sorin Vinturis <svintu...@cloudbasesolutions.com>
Acked-by: Eitan Eliahu <elia...@vmware.com>
---
 datapath-windows/ovsext/ovsext.vcxproj | 35 +++++++++++++++++++++++++++++++++-
 1 file changed, 34 insertions(+), 1 deletion(-)

diff --git a/datapath-windows/ovsext/ovsext.vcxproj 
b/datapath-windows/ovsext/ovsext.vcxproj
index 88c9122..693bc50 100644
--- a/datapath-windows/ovsext/ovsext.vcxproj
+++ b/datapath-windows/ovsext/ovsext.vcxproj
@@ -102,7 +102,7 @@
   <PropertyGroup>
     <TargetName>OVSExt</TargetName>
   </PropertyGroup>
-  <ItemDefinitionGroup>
+  <ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Win8 
+ Release|x64'">
     <ClCompile>
       
<PreprocessorDefinitions>%(PreprocessorDefinitions);NDIS_WDM=1;NDIS630=1</PreprocessorDefinitions>
     </ClCompile>
@@ -113,6 +113,39 @@
       
<PreprocessorDefinitions>%(PreprocessorDefinitions);NDIS_WDM=1;NDIS630=1</PreprocessorDefinitions>
     </ResourceCompile>
   </ItemDefinitionGroup>
+  <ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Win8.1 
Release|x64'">
+    <ClCompile>
+      
<PreprocessorDefinitions>%(PreprocessorDefinitions);NDIS_WDM=1;NDIS640=1</PreprocessorDefinitions>
+    </ClCompile>
+    <Midl>
+      
<PreprocessorDefinitions>%(PreprocessorDefinitions);NDIS_WDM=1;NDIS640=1</PreprocessorDefinitions>
+    </Midl>
+    <ResourceCompile>
+      
<PreprocessorDefinitions>%(PreprocessorDefinitions);NDIS_WDM=1;NDIS640=1</PreprocessorDefinitions>
+    </ResourceCompile>
+  </ItemDefinitionGroup>
+  <ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Win8 
Debug|x64'">
+    <ClCompile>
+      
<PreprocessorDefinitions>%(PreprocessorDefinitions);NDIS_WDM=1;NDIS630=1</PreprocessorDefinitions>
+    </ClCompile>
+    <Midl>
+      
<PreprocessorDefinitions>%(PreprocessorDefinitions);NDIS_WDM=1;NDIS630=1</PreprocessorDefinitions>
+    </Midl>
+    <ResourceCompile>
+      
<PreprocessorDefinitions>%(PreprocessorDefinitions);NDIS_WDM=1;NDIS630=1</PreprocessorDefinitions>
+    </ResourceCompile>
+  </ItemDefinitionGroup>
+  <ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Win8.1 
Debug|x64'">
+    <ClCompile>
+      
<PreprocessorDefinitions>%(PreprocessorDefinitions);NDIS_WDM=1;NDIS640=1</PreprocessorDefinitions>
+    </ClCompile>
+    <Midl>
+      
<PreprocessorDefinitions>%(PreprocessorDefinitions);NDIS_WDM=1;NDIS640=1</PreprocessorDefinitions>
+    </Midl>
+    <ResourceCompile>
+      
<PreprocessorDefinitions>%(PreprocessorDefinitions);NDIS_WDM=1;NDIS640=1</PreprocessorDefinitions>
+    </ResourceCompile>
+  </ItemDefinitionGroup>
   <ItemDefinitionGroup>
     <Link>
       
<AdditionalDependencies>%(AdditionalDependencies);$(DDK_LIB_PATH)\ndis.lib;$(DDK_LIB_PATH)\fwpkclnt.lib;$(SDK_LIB_PATH)\uuid.lib;$(DDK_LIB_PATH)\netio.lib</AdditionalDependencies>
--
1.9.0.msysgit.0
_______________________________________________
dev mailing list
dev@openvswitch.org
https://urldefense.proofpoint.com/v2/url?u=http-3A__openvswitch.org_mailman_listinfo_dev&d=AAIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=CWsgHUxi6ExLXY798tmo3LJ4e3geGYp56lkcH-5cLCY&m=LrfnoGch9G6_TPkJ5ZHRsNTI3exzEFBiWaD6dUH_zFQ&s=n4bOIxBT0f4aoMlS1R30ZavdqgdgJLZAj9W5yK21nAM&e=
 
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to