Acked-by: Jarno Rajahalme <jrajaha...@nicira.com>

On Nov 14, 2014, at 9:07 AM, Daniele Venturino <daniele.ventur...@m3s.it> wrote:

> Commit message:
> 
> "Fix Topology Change State Machine transition. 
> Accordingly to the 802.1D-2004 standard, the transition from the 
> TOPOLOGY_CHANGE_SM_NOTIFIED_TCN_EXEC state
> should go to the TOPOLOGY_CHANGE_SM_NOTIFIED_TC_EXEC state and not to the 
> TOPOLOGY_CHANGE_SM_ACTIVE.
> 
> See 17.31 of 802.1D-2004 standard."
> 
> Daniele
> 
> 2014-11-14 0:23 GMT+01:00 Jarno Rajahalme <jrajaha...@nicira.com>:
> This patch needs a proper commit message. Explain what was wrong, and why the 
> fix is correct.
> 
> Regards,
> 
>   Jarno
> 
> On Nov 6, 2014, at 7:31 AM, Daniele Venturino <daniele.ventur...@m3s.it> 
> wrote:
> 
> > Signed-off-by: Daniele Venturino <daniele.ventur...@m3s.it>
> > ---
> > lib/rstp-state-machines.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/lib/rstp-state-machines.c b/lib/rstp-state-machines.c
> > index 1912d7e..5c03385 100644
> > --- a/lib/rstp-state-machines.c
> > +++ b/lib/rstp-state-machines.c
> > @@ -1948,7 +1948,7 @@ topology_change_sm(struct rstp_port *p)
> >         break;
> >     case TOPOLOGY_CHANGE_SM_NOTIFIED_TCN_EXEC:
> >         new_tc_while(p);
> > -        p->topology_change_sm_state = TOPOLOGY_CHANGE_SM_ACTIVE;
> > +        p->topology_change_sm_state = TOPOLOGY_CHANGE_SM_NOTIFIED_TC_EXEC;
> >         break;
> >     default:
> >         OVS_NOT_REACHED();
> > --
> > 1.8.1.2
> >
> 
> 

_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to