On Thu, Nov 13, 2014 at 10:59:41AM -0200, Flavio Leitner wrote:
> On Thu, Nov 13, 2014 at 12:28:39PM +0100, Thomas Graf wrote:
> > v2 with the already merged patches omitted and comments addressed:
> >  - Dropped convertion to automake subdir and use of prefix
> >    header variable as per Ben's suggestion.
> >  - Fixes trailing whitespace as spotted by Flavio.
> >  - Removed redundant header install instructions in Fedora spec as
> >    suggested by Flavio
> >  - No longer expose include/openvswitch/lib and config.h in
> >    openvswitch-devel Fedora package
> > 
> > Now that shared libraries can be built, the next step is to
> > prepare the build system to make headers installable and ease
> > linking with the help of pkg-config files.
> > 
> > This series:
> >  * Provides pkg-config files for all libraries
> >    * Static linking can be achieved with:
> >        $ pkg-config libopenvswitch --libs --static
> >  * Installs the already public headers in include/
> >    * The openvswitch/ and openflow/ structure is preserved
> >  * Fixup installed headers of the Fedora openvswitch-devel package
> > 
> > The library is still mostly unusable at this point without an OVS
> > source tree to acquire the headers. A next series will start exposing
> > existing APIs by moving some of the them to public headers.
>  
> The series looks good to me.  The spec change went further than
> what I had proposed, but it's a step in the right direction.
> Thanks Thomas!
> 
> Acked-by: Flavio Leitner <f...@redhat.com>

Thanks for reviewing!  It is really helpful since I don't know Red Hat
well myself.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to