On Tue, Nov 11, 2014 at 10:08:10AM +0900, Simon Horman wrote: > On Mon, Nov 10, 2014 at 09:58:38AM -0800, Ben Pfaff wrote: > > On Mon, Nov 10, 2014 at 01:47:52PM +0900, Simon Horman wrote: > > > This is in preparation for supporting (draft) OpenFlow1.5 group mod. > > > > > > EXT-350 > > > Signed-off-by: Simon Horman <simon.hor...@netronome.com> > > > > Thanks. > > > > I believe that after this patch, Open vSwitch will malfunction if OF1.5+ > > is enabled and an OF1.5+ group mod is received, because it will > > interpret the OF1.5+ group mod as if it were an OF1.1 group mod. If > > this is the case then I would prefer to see this squashed with whatever > > patch implements the OF1.5+ group mod. > > My reading of the situation is slightly different: that OF1.5+ group > mod handling is incorrect both with and without this patch. Regardless, > I will squash this change into the following patch of the series > which implements encoding and decoding of OF1.5+ group mod (less the > new bucket commands: that may be a candidate for further squashing depending > on how you feel about it).
I guess it's a matter of opinion. Thanks, though. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
