[ovs-dev] [PATCH v3 1/3] tunnel: Convert rwlock to fat-rwlock.

[Pravin B Shelar]

Tunnel lookup is done in slow path but DPDK tunneling
slow path is called in PMD context. Therefore it is
better to convert rwlock to fat rwlock.

Signed-off-by: Pravin B Shelar <pshe...@nicira.com>
---
 ofproto/ofproto-dpif.c |    1 +
 ofproto/tunnel.c       |   35 ++++++++++++++++++++++++-----------
 ofproto/tunnel.h       |    1 +
 3 files changed, 26 insertions(+), 11 deletions(-)

diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
index db306c5..3e75d33 100644
--- a/ofproto/ofproto-dpif.c
+++ b/ofproto/ofproto-dpif.c
@@ -1226,6 +1226,7 @@ construct(struct ofproto *ofproto_)
     ofproto->mbridge = mbridge_create();
     ofproto->has_bonded_bundles = false;
     ofproto->lacp_enabled = false;
+    ofproto_tunnel_init();
     ovs_mutex_init_adaptive(&ofproto->stats_mutex);
     ovs_mutex_init(&ofproto->vsp_mutex);
 
diff --git a/ofproto/tunnel.c b/ofproto/tunnel.c
index a9eecff..83be8d9 100644
--- a/ofproto/tunnel.c
+++ b/ofproto/tunnel.c
@@ -20,6 +20,7 @@
 #include "byte-order.h"
 #include "connectivity.h"
 #include "dynamic-string.h"
+#include "fat-rwlock.h"
 #include "hash.h"
 #include "hmap.h"
 #include "netdev.h"
@@ -58,7 +59,7 @@ struct tnl_port {
     struct tnl_match match;
 };
 
-static struct ovs_rwlock rwlock = OVS_RWLOCK_INITIALIZER;
+static struct fat_rwlock rwlock;
 
 /* Tunnel matches.
  *
@@ -122,6 +123,18 @@ static const char *tnl_port_get_name(const struct tnl_port 
*)
     OVS_REQ_RDLOCK(rwlock);
 static void tnl_port_del__(const struct ofport_dpif *) OVS_REQ_WRLOCK(rwlock);
 
+void
+ofproto_tunnel_init(void)
+{
+    static bool initialized = false;
+
+    if (initialized) {
+        return;
+    }
+    initialized = true;
+    fat_rwlock_init(&rwlock);
+}
+
 static bool
 tnl_port_add__(const struct ofport_dpif *ofport, const struct netdev *netdev,
                odp_port_t odp_port, bool warn)
@@ -183,9 +196,9 @@ void
 tnl_port_add(const struct ofport_dpif *ofport, const struct netdev *netdev,
              odp_port_t odp_port) OVS_EXCLUDED(rwlock)
 {
-    ovs_rwlock_wrlock(&rwlock);
+    fat_rwlock_wrlock(&rwlock);
     tnl_port_add__(ofport, netdev, odp_port, true);
-    ovs_rwlock_unlock(&rwlock);
+    fat_rwlock_unlock(&rwlock);
 }
 
 /* Checks if the tunnel represented by 'ofport' reconfiguration due to changes
@@ -200,7 +213,7 @@ tnl_port_reconfigure(const struct ofport_dpif *ofport,
     struct tnl_port *tnl_port;
     bool changed = false;
 
-    ovs_rwlock_wrlock(&rwlock);
+    fat_rwlock_wrlock(&rwlock);
     tnl_port = tnl_find_ofport(ofport);
     if (!tnl_port) {
         changed = tnl_port_add__(ofport, netdev, odp_port, false);
@@ -212,7 +225,7 @@ tnl_port_reconfigure(const struct ofport_dpif *ofport,
         tnl_port_add__(ofport, netdev, odp_port, true);
         changed = true;
     }
-    ovs_rwlock_unlock(&rwlock);
+    fat_rwlock_unlock(&rwlock);
     return changed;
 }
 
@@ -247,9 +260,9 @@ tnl_port_del__(const struct ofport_dpif *ofport) 
OVS_REQ_WRLOCK(rwlock)
 void
 tnl_port_del(const struct ofport_dpif *ofport) OVS_EXCLUDED(rwlock)
 {
-    ovs_rwlock_wrlock(&rwlock);
+    fat_rwlock_wrlock(&rwlock);
     tnl_port_del__(ofport);
-    ovs_rwlock_unlock(&rwlock);
+    fat_rwlock_unlock(&rwlock);
 }
 
 /* Looks in the table of tunnels for a tunnel matching the metadata in 'flow'.
@@ -265,7 +278,7 @@ tnl_port_receive(const struct flow *flow) 
OVS_EXCLUDED(rwlock)
     const struct ofport_dpif *ofport;
     struct tnl_port *tnl_port;
 
-    ovs_rwlock_rdlock(&rwlock);
+    fat_rwlock_rdlock(&rwlock);
     tnl_port = tnl_find(flow);
     ofport = tnl_port ? tnl_port->ofport : NULL;
     if (!tnl_port) {
@@ -294,7 +307,7 @@ tnl_port_receive(const struct flow *flow) 
OVS_EXCLUDED(rwlock)
     }
 
 out:
-    ovs_rwlock_unlock(&rwlock);
+    fat_rwlock_unlock(&rwlock);
     return ofport;
 }
 
@@ -371,7 +384,7 @@ tnl_port_send(const struct ofport_dpif *ofport, struct flow 
*flow,
     char *pre_flow_str = NULL;
     odp_port_t out_port;
 
-    ovs_rwlock_rdlock(&rwlock);
+    fat_rwlock_rdlock(&rwlock);
     tnl_port = tnl_find_ofport(ofport);
     out_port = tnl_port ? tnl_port->match.odp_port : ODPP_NONE;
     if (!tnl_port) {
@@ -440,7 +453,7 @@ tnl_port_send(const struct ofport_dpif *ofport, struct flow 
*flow,
     }
 
 out:
-    ovs_rwlock_unlock(&rwlock);
+    fat_rwlock_unlock(&rwlock);
     return out_port;
 }
 
diff --git a/ofproto/tunnel.h b/ofproto/tunnel.h
index 27a2f7d..cdcbb77 100644
--- a/ofproto/tunnel.h
+++ b/ofproto/tunnel.h
@@ -28,6 +28,7 @@
 struct ofport_dpif;
 struct netdev;
 
+void ofproto_tunnel_init(void);
 bool tnl_port_reconfigure(const struct ofport_dpif *, const struct netdev *,
                           odp_port_t);
 
-- 
1.7.1

_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev