On Wed, Oct 29, 2014 at 03:12:00PM -0700, Jarno Rajahalme wrote: > Add transport port modifications to the existing frags handling test > case. > > This demonstrates incorrect behavior by not moving the destination > port number to source port in normal mode for first fragment, as the > transport port numbers have been zeroed and the move has no effect, > and by allowing moves to/from transport ports on later fragments > (which do not have a transport header). > > Next patches fix these problems. > > Signed-off-by: Jarno Rajahalme <jrajaha...@nicira.com>
This is a thorny corner case in OpenFlow. OpenFlow 1.0 and 1.1 have flow charts for flow extraction that make it clear that, if a packet is a fragment, then the transport ports should not even be extracted. I have always taken this to mean that "set L4 port" actions shouldn't be supported in that case. Yet, OVS does support them, and they behave really oddly for now. Furthermore, the flow charts and the detailed parsing spec that they represented were removed from OpenFlow 1.2 and later because they could not be implemented exactly as shown on hardware. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
