On Fri, Oct 31, 2014 at 10:05:48AM -0400, Ludovic Beliveau wrote: > +#ifdef __LITTLE_ENDIAN > + u_int16_t conn_type:4; > + u_int16_t smlt_id:12; > +#else > + u_int16_t smlt_id:12; > + u_int16_t conn_type:4; > +#endif
I only have a couple of minutes today, so this isn't a full review, but it caught my eye at a glance. I don't think this is a good way to test for endianness, because with glibc headers it will always test as little-endian. glibc headers always define __LITTLE_ENDIAN to 1234 and __BIG_ENDIAN to 4321. It looks like our other headers use WORDS_BIGENDIAN as the test. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
