Looks good. Acked-by: Andy Zhou <az...@nicira.com>
On Mon, Oct 20, 2014 at 3:05 PM, Ben Pfaff <b...@nicira.com> wrote: > This feature bit was overlooked when we added support for group stats. > > Reported-by: Anup Khadka <khadka...@gmail.com> > Signed-off-by: Ben Pfaff <b...@nicira.com> > --- > ofproto/ofproto.c | 3 ++- > tests/ofproto.at | 4 ++-- > 2 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c > index 2cb93b0..8bd5f03 100644 > --- a/ofproto/ofproto.c > +++ b/ofproto/ofproto.c > @@ -2997,7 +2997,8 @@ handle_features_request(struct ofconn *ofconn, const > struct ofp_header *oh) > features.n_buffers = pktbuf_capacity(); > features.n_tables = ofproto_get_n_visible_tables(ofproto); > features.capabilities = (OFPUTIL_C_FLOW_STATS | OFPUTIL_C_TABLE_STATS | > - OFPUTIL_C_PORT_STATS | OFPUTIL_C_QUEUE_STATS); > + OFPUTIL_C_PORT_STATS | OFPUTIL_C_QUEUE_STATS | > + OFPUTIL_C_GROUP_STATS); > if (arp_match_ip) { > features.capabilities |= OFPUTIL_C_ARP_MATCH_IP; > } > diff --git a/tests/ofproto.at b/tests/ofproto.at > index 51efd37..3278287 100644 > --- a/tests/ofproto.at > +++ b/tests/ofproto.at > @@ -482,7 +482,7 @@ do > AT_CHECK_UNQUOTED([STRIP_XIDS stdout], [0], [dnl > OFPT_FEATURES_REPLY (OF1.2): dpid:fedcba9876543210 > n_tables:254, n_buffers:256 > -capabilities: FLOW_STATS TABLE_STATS PORT_STATS QUEUE_STATS > +capabilities: FLOW_STATS TABLE_STATS PORT_STATS GROUP_STATS QUEUE_STATS > LOCAL(br0): addr:aa:55:aa:55:00:00 > config: $config > state: $state > @@ -513,7 +513,7 @@ do > AT_CHECK_UNQUOTED([STRIP_XIDS stdout], [0], [dnl > OFPT_FEATURES_REPLY (OF1.4): dpid:fedcba9876543210 > n_tables:254, n_buffers:256 > -capabilities: FLOW_STATS TABLE_STATS PORT_STATS QUEUE_STATS > +capabilities: FLOW_STATS TABLE_STATS PORT_STATS GROUP_STATS QUEUE_STATS > OFPST_PORT_DESC reply (OF1.4): > LOCAL(br0): addr:aa:55:aa:55:00:00 > config: $config > -- > 1.7.10.4 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > http://openvswitch.org/mailman/listinfo/dev _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev