That would make sense, if the patch added an implementation of these actions, but I do not see one.
The new actions must be added at the end of the list, not in the middle, so that existing actions are not renumbered. On Wed, Oct 15, 2014 at 11:00:38AM +0800, Liuyongqiang (A) wrote: > I could not find any place to define the enum OVS_ACTION_ATTR_PUSH_PBB and > OVS_ACTION_ATTR_POP_PBB, > I compare the code of openvswitch-2.0.0, I find that the openvswitch.h under > the include/linux/, > but the openvswitch-master is under the datapath/linux/compat/include/linux/. > > On 2014/10/10 23:24, Ben Pfaff wrote: > > On Fri, Oct 10, 2014 at 01:39:56PM +0800, Liuyongqiang(A) wrote: > >> From: liuyongqiang <liu.liuyongqi...@huawei.com> > >> > >> this patch work for the ovs serporting the IEEE 802.1ah > >> protocol(Mac in Mac or PBB) > >> > >> IEEE 802.1ah (PBB or MAC-in-MAC): > >> PBB (also known as MAC-in-MAC) is used by SPs to resolve these problems. > >> PBB introduces a hierarchical network architecture with associated new > >> frame formats which extend the work completed by Provider Bridges (IEEE > >> 802.1ad). In PBB architecture, Customer networks (using 802.1q bridging) > >> are aggregated into Provider Bridged networks (using 802.1ad). These, in > >> turn, are aggregated into PBB networks which utilize the 802.1ah frame > >> format. The frame format employs a MAC tunneling encapsulation scheme for > >> tunneling customer Ethernet frames within provider Ethernet frames across > >> the PBBN. A VLAN ID is used to segregate the backbone into broadcast > >> domains and a new 24-bit service identifier (I-SID) is defined and used to > >> associate a given Customer MAC frame with a provider service instance. > >> There is a clear segregation between I-SIDs and B-VLANs which was missing > >> in 802.1ad. > >> PBB network (PBBN) has following benefits: > >> 1.Imposes no change to Ethernet switching process in the core bridges. > >> 2.Supports Ethernet private line (E-Line), Ethernet Transparent (E-LAN) > >> and Ethernet Tree (E-Tree) services. > >> 3.Provides a clear demarcation point between the customer and provider > >> domain. > >> 4.Learns customer MAC addresses only through the backbone edge bridges > >> (BEB). > >> 5.Supports upto 2^24 service instances. > >> 6.Achieves additional PBBN scaling and interconnection using hierarchical > >> and peer PBBN features. > >> > >> this patch defined the basic data structure and basic function of PBB > >> actions. > >> > >> Signed-off-by: liuyongqiang <liu.liuyongqi...@huawei.com> > > > > The basic structure looks correct. > > > > We should not modify any of the datapath definitions > > (e.g. openvswitch.h) until there is an implementation. > > > > > _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
