On Tue, Oct 07, 2014 at 12:23:34AM +1300, Joe Stringer wrote:
> Add the 128-bit murmurhash by Austin Appleby, r150 from:
> http://code.google.com/p/smhasher/source/browse/trunk/MurmurHash3.cpp
> 
> Signed-off-by: Joe Stringer <joestrin...@nicira.com>
> Acked-by: Ben Pfaff <b...@nicira.com>

Compiling on i386, I get:

    ../lib/hash.c:77:1: error: static declaration of 'hash_bytes128' follows
          non-static declaration
    hash_bytes128(const void *p_, size_t len, uint32_t basis, ovs_u128 *out)
    ^
    ../lib/hash.h:36:6: note: previous declaration is here
    void hash_bytes128(const void *_, size_t n_bytes, uint32_t basis,
         ^
    1 error generated.

which is easily fixed with:

    diff --git a/lib/hash.c b/lib/hash.c
    index fe742cd..1042c97 100644
    --- a/lib/hash.c
    +++ b/lib/hash.c
    @@ -73,7 +73,7 @@ hash_words64__(const uint64_t p[], size_t n_words, 
uint64_t basis)
     }

     #if !(defined(__x86_64__))
    -static void
    +void
     hash_bytes128(const void *p_, size_t len, uint32_t basis, ovs_u128 *out)
     {
         const uint32_t c1 = 0x239b961b;

_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to