On Thu, Oct 02, 2014 at 06:42:55PM -0400, Ludovic Beliveau wrote: > This is the final commit in the series of commits that deliver initial support > for Auto-Attach. Specifically this commit delivers auto-attach support to the > OVS bridge layer as well as the new auto-attach commands. The OVSDB schema is > modified to define the new auto-attach entries. The man pages and unit tests > are also updated. > > Signed-off-by: Ludovic Beliveau <ludovic.beliv...@windriver.com> > Signed-off-by: Dennis Flynn <drfl...@avaya.com>
Thanks for the patch! Some patch in the series should add a notes to NEWS, to let users know about the new feature. I don't understand the value of a command to delete the database, as this adds to ovs-ctl. (If it is valuable, it should be documented in the ovs-ctl manpage and usable via the various initscripts.) The ovs-vsctl program can talk to any Open vSwitch instance, not just to an instance on the machine where it runs, so even if it makes sense to make auto-attach a configuration time option for ovs-vswitchd, I don't think it makes sense to apply that same option to ovs-vsctl. It would be nice to say a few words in ovs-vsctl(8) and vswitch.xml about what auto-attach is, in what circumstances one would use it, and where one should go for more information. Regarding the database schema, it looks like AutoAttachMapping is used as a map from an integer to an integer. Do you expect to need to add more data than (isid,vlan) pairs in the future? If not, then it would be easier to make the "mappings" column just an integer-integer map rather than involving another table. It also seems odd that the isid and vlan values in AutoAttachMapping are optional; wouldn't one need to provide both in each case? Thanks, Ben. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
