[adding the list back]
I think that that is somewhat separate from the documentation. I
think that the documentation should probably focus on the
protocol-specific field names these days, and document tp_src and
tp_dst as obsolete. I sent out a patch:
http://openvswitch.org/pipermail/dev/2014-October/046951.html
I'm not sure what you mean for OXM/NXM here and what you propose for
it. Can you explain further?
On Mon, Oct 06, 2014 at 11:01:31AM -0700, Alex Wang wrote:
> Hey Ben,
>
> I checked the code. Since we overlap the "tcp_src" and "tp_src", "tp_src"
> use the same prerequisite as "tcp_src". Also, it is not just about 'learn'
> action, the ofproto/trace's 'br-flow' will also have the same issue (i.e.
> cannot
> use tp_src/dst if nw_proto is udp).
>
>
> {
> MFF_TCP_SRC, "tcp_src", "tp_src",
> MF_FIELD_SIZES(be16),
> MFM_FULLY,
> MFS_DECIMAL,
> MFP_TCP,
> true,
> NXM_OF_TCP_SRC, "NXM_OF_TCP_SRC",
> OXM_OF_TCP_SRC, "OXM_OF_TCP_SRC", OFP12_VERSION,
> OFPUTIL_P_ANY,
> OFPUTIL_P_NXM_OXM_ANY,
> -1,
> }, {
> MFF_TCP_DST, "tcp_dst", "tp_dst",
> MF_FIELD_SIZES(be16),
> MFM_FULLY,
> MFS_DECIMAL,
> MFP_TCP,
> true,
> NXM_OF_TCP_DST, "NXM_OF_TCP_DST",
> OXM_OF_TCP_DST, "OXM_OF_TCP_DST", OFP12_VERSION,
> OFPUTIL_P_ANY,
> OFPUTIL_P_NXM_OXM_ANY,
> -1,
> }, {
>
>
> One way to lift it is to create a separate 'mf_field' instance for 'tp_src'
> and
> 'tp_dst'. For the prerequisite, we can ask the 'nw_proto' to be tcp *or*
> udp.
>
> The only thing is that NXM, OXM does not have _OF_TP_SRC/DST fields.
> So, we may just use _OF_TCP_SRC/DST for the 'tp_src/dst'. I checked, it
> is not used.
>
> What do you think?
>
>
> Thanks,
> Alex Wang,
>
> On Thu, Oct 2, 2014 at 8:38 AM, Ben Pfaff <[email protected]> wrote:
>
> > On Wed, Oct 01, 2014 at 08:58:07PM -0700, Alex Wang wrote:
> > > OVS implements specific keywords like udp_src/udp_dst
> > > to match on L4 header port in OpenFlow flows. However,
> > > these keywords are not documented in the ovs-ofctl
> > > manpage. This commit fixes it.
> > >
> > > VMware-BZ: #1333815
> > >
> > > Signed-off-by: Alex Wang <[email protected]>
> >
> > Unfortunately, I don't actually understand the new text. It sounds like
> > this is really about the "learn" action. Maybe you should give an
> > example of what needs to be done differently with "learn"? Or maybe the
> > problem is that "learn" is too hard to use. What can we do to improve
> > it?
> >
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
