On Wed, Sep 24, 2014 at 11:31:44AM -0700, Jarno Rajahalme wrote:
>     These makes cmap_find 10% faster on GCC 4.7 (-O2 -g).
> 
> Signed-off-by: Jarno Rajahalme <jrajaha...@nicira.com>

I'm surprised it makes so much difference!

What if we additionally change:
    if (OVS_UNLIKELY(counter_changed(b1, c1))) {
        goto retry;
    }
    if (node) {
        return node;
    }
to this?
    if (node) {
        if (OVS_UNLIKELY(counter_changed(b1, c1))) {
            goto retry;
        }
        return node;
    }
I can see an argument that it would help, and a different one that it
would hurt.

Either way:
Acked-by: Ben Pfaff <b...@nicira.com>
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to