Acked-by: Eitan Eliahu <elia...@vmware.com>
-----Original Message-----
From: Samuel Ghinet [mailto:sghi...@cloudbasesolutions.com]
Sent: Tuesday, September 30, 2014 7:47 AM
To: dev@openvswitch.org
Cc: Alin Serdean; Nithin Raju; Eitan Eliahu; Ankur Sharma
Subject: [PATCH 04/14] datapath-windows: Update OVS_SWITCH_CONTEXT: external
and internal port
The fields externalVport and internalVport of the OVS_SWITCH_CONTEXT struct are
currently defined as PVOID. However, all over the code they are used as
POVS_VPORT_ENTRY. In order to improve clarity and reduce the need for useless
casts to POVS_VPORT_ENTRY, this patch changes the type from PVOID to
POVS_VPORT_ENTRY.
This patch does not cleanup the code that already uses casts to
POVS_VPORT_ENTRY. This cleanup can be done later on as well.
Signed-off-by: Samuel Ghinet <sghi...@cloudbasesolutions.com>
---
datapath-windows/ovsext/Switch.h | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/datapath-windows/ovsext/Switch.h b/datapath-windows/ovsext/Switch.h
index 5199268..f7acd87 100644
--- a/datapath-windows/ovsext/Switch.h
+++ b/datapath-windows/ovsext/Switch.h
@@ -53,6 +53,8 @@
#define OVS_HASH_BASIS 0x13578642
+typedef struct _OVS_VPORT_ENTRY *POVS_VPORT_ENTRY;
+
typedef struct _OVS_DATAPATH
{
PLIST_ENTRY flowTable; // Contains OvsFlows.
@@ -104,8 +106,8 @@ typedef struct _OVS_SWITCH_CONTEXT
NDIS_SWITCH_PORT_ID externalPortId;
NDIS_SWITCH_PORT_ID internalPortId;
- PVOID externalVport; // the virtual adapter vport
- PVOID internalVport;
+ POVS_VPORT_ENTRY externalVport; // the virtual adapter vport
+ POVS_VPORT_ENTRY internalVport;
PVOID *vportArray;
PLIST_ENTRY nameHashArray; // based on ovsName
--
1.8.3.msysgit.0
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
