Hi Alin, I'm wondering if you could send a patch with your modified netdev code. Is this something that we could leverage? Thanks, Eitan
-----Original Message----- From: Alin Serdean [mailto:aserd...@cloudbasesolutions.com] Sent: Tuesday, September 30, 2014 8:23 AM To: Nithin Raju; Samuel Ghinet Cc: dev@openvswitch.org; Eitan Eliahu; Ankur Sharma Subject: RE: [PATCH 14/14] datapath-windows: Fix potential crash in OvsInitConfiguredSwitchNics: virtPort Hi Nithin, We used a modified version of netdev-windows. Alin. -----Mesaj original----- De la: Nithin Raju [mailto:nit...@vmware.com] Trimis: Tuesday, September 30, 2014 6:09 PM Către: Samuel Ghinet Cc: dev@openvswitch.org; Alin Serdean; Eitan Eliahu; Ankur Sharma Subiect: Re: [PATCH 14/14] datapath-windows: Fix potential crash in OvsInitConfiguredSwitchNics: virtPort On Sep 30, 2014, at 8:03 AM, Samuel Ghinet <sghi...@cloudbasesolutions.com> wrote: > If the hyper-v switch port type is external, then the function > OvsInitConfiguredSwitchNics allocates a vport, and if allocation > succeeds, it procedes with the initialization. However, at this point, > virtPort may happen to be null, but check against virtPort was not > made - this means that if virtPort was null, later on its fields would > try to be accessed. > > This patch adds a check for virtPort as well, so that the fields of > virtPort will not be accessed if virtPort is NULL. > > Signed-off-by: Samuel Ghinet <sghi...@cloudbasesolutions.com> hi Samuel, Thanks for the patch series. Can you pls. add some notes about validation performed. Did you make any userspace changes? thanks, Nithin _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
